Refactor readlink_f to common helpers #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `readlink_f example` would result in `path/to/example/example`, duplicating the the relative directory.
OJFord
force-pushed
the
refactor-readlink
branch
from
1784a4f
to
7df205d
Compare
|
Bah, I see why this was done now, the existing use of readlink_f is in finding TFENV_ROOT, and helpers.sh is sourced from within that dir. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of fixing #355's use of
realpath --relative-tofor macOS, I tried to usereadlink --canonicalize/-fwhich had a similar problem, and through that noticed the extensive extant use of areadlink_ffunction to achieve that functionality. The same function is currently replicated 23 times through the repo.In the interest of readability, maintainability etc., this PR refactors that to the common helpers.sh, exporting it for use everywhere without redefinition.
#355 also revealed a bug in the implementation I copied again, which I subsequently fixed in that instance. That's reproduced here too (and thus for all uses of the function) in 1784a4f.
(This is based on top of #355, since that PR adds another instance of this function. I'll rebase this once that's merged - please consider this a draft until then.)